Update to use TransactionHeader#781
Merged
PhilippGackstatter merged 9 commits intonextfrom Apr 3, 2025
Merged
Conversation
PhilippGackstatter
changed the title
TransactionHeaderTransactionHeader
Collaborator
There was a problem hiding this comment.
Hmm. How are these toml changes passing the taplo lint check?
Are the lines too long and it gave up?
Contributor
Author
There was a problem hiding this comment.
I was wondering about that too but I just ran make lint. I guess they're too long and that's what it fell back to.
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
approved these changes
Apr 3, 2025
bobbinth
reviewed
Apr 4, 2025
bobbinth
reviewed
Apr 4, 2025
SantiagoPittella
pushed a commit
that referenced
this pull request
May 16, 2025
* feat: Update to use `TransactionHeader` * chore: Add changelog * chore: make lint * chore: Remove changelog entry * chore: Update used miden-base version * chore: Update to latest miden base * chore: Use next branch of miden-base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update usages of account updates and batch and block to use the newly introduced
TransactionHeaderfrom 0xMiden/miden-base#1247.These are relatively minor updates. I think the only thing worth calling out is the insertion of the transactions into the DB. Currently the table has these fields:
We could insert more data here from the
TransactionHeader, but how exactly depends on some details I'm not familiar with, like should we insert notes into this table and reference them via a foreign key or is that a bad idea because we remove notes from the notes table when they're consumed?.If we want to support the explorer to get the transactions of a block, then we probably have to insert the full headers?